This repository has been archived by the owner on Mar 29, 2022. It is now read-only.
Changed Tests and added Ignore-tags if needed for example if further … #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryouzanpaku
reviewed
Mar 2, 2021
| @@ -51,7 +51,7 @@ public void testRateRetrieval() throws HttpCommunicationException, ParseExceptio | |||
| Date orderDate = getDate("21.06.2019"); | |||
| List<HirePurchaseRatePlan> rateList = getHeidelpay().hirePurchaseRates(BigDecimal.TEN, Currency.getInstance("EUR"), effectiveInterestRate, orderDate); | |||
| assertNotNull(rateList); | |||
| assertEquals(6, rateList.size()); | |||
| assertEquals(4, rateList.size()); | |||
There was a problem hiding this comment.
I think this value might vary depending on merchant configuration. Changing that might break tests for an other merchant.
There was a problem hiding this comment.
Yes, but I am mainly working on this with this Keypair so I think this should be set to the values of the Java-SDK Merchant.
There was a problem hiding this comment.
Tests should also work for every merchant out there who wants to run them.
sixer1182
suggested changes
Mar 2, 2021
Comment on lines
+244
to
+245
| paypage.setTermsAndConditionUrl(new URL("https://www.unzer.com/en/privacy-statement/")); | ||
| paypage.setPrivacyPolicyUrl(new URL("https://www.unzer.com/en/privacy-statement/")); |
| paypage.setHelpUrl(new URL("https://www.unzer.com/en/support/")); | ||
| paypage.setImprintUrl(new URL("https://www.unzer.com/en/impressum/")); | ||
| paypage.setPrivacyPolicyUrl(new URL("https://www.unzer.com/en/datenschutz/")); | ||
| paypage.setTermsAndConditionUrl(new URL("https://www.unzer.com/en/datenschutz/")); |
There was a problem hiding this comment.
This should be a different route.
So it is clear every link is modified separately.
| @@ -51,7 +51,7 @@ public void testRateRetrieval() throws HttpCommunicationException, ParseExceptio | |||
| Date orderDate = getDate("21.06.2019"); | |||
| List<HirePurchaseRatePlan> rateList = getHeidelpay().hirePurchaseRates(BigDecimal.TEN, Currency.getInstance("EUR"), effectiveInterestRate, orderDate); | |||
| assertNotNull(rateList); | |||
| assertEquals(6, rateList.size()); | |||
| assertEquals(4, rateList.size()); | |||
There was a problem hiding this comment.
Are you sure this will always be 4?
Better check it is >0 or not empty.
| @@ -51,7 +51,7 @@ public void testRateRetrieval() throws HttpCommunicationException, ParseExceptio | |||
| Date orderDate = getDate("21.06.2019"); | |||
| List<InstallmentSecuredRatePlan> rateList = getHeidelpay().installmentSecuredRates(BigDecimal.TEN, Currency.getInstance("EUR"), effectiveInterestRate, orderDate); | |||
| assertNotNull(rateList); | |||
| assertEquals(6, rateList.size()); | |||
| assertEquals(4, rateList.size()); | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…configuration is needed for the Testing-Keypair.