Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove omitempty from EO rule disable attrib #148

Merged

Conversation

imjaroiswebdev
Copy link
Collaborator

Omitting EventOrchestrationPathRule.Disable boolean attribute is not allowing to enable/re-enable routing rules for EO paths.

So, this update is meant to address PagerDuty/terraform-provider-pagerduty#652

Copy link
Contributor

@alenapan alenapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for fixing this!

@imjaroiswebdev imjaroiswebdev merged commit a2cbd99 into heimweh:master Feb 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants