Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alexharvey/clean up docs #11

Merged
merged 3 commits into from
Jul 8, 2018
Merged

Alexharvey/clean up docs #11

merged 3 commits into from
Jul 8, 2018

Conversation

alex-harvey-z3q
Copy link
Collaborator

  • Add the Puppet-blacksmith Gem

    This should make it easier to release a new version.

  • Clean up README.md

    Clean up the Markdown formatting. Some slightly better examples. Also,
    remove unnecessary instruction to include wait_for. That is not required
    to make a custom type available. Add a section on testing.

    Some minor changes to comments in the code.

Clean up the Markdown formatting. Some slightly better examples. Also,
remove unnecessary instruction to include wait_for. That is not required
to make a custom type available. Add a section on testing.

Some minor changes to comments in the code.
This should make it easier to release a new version.
@alex-harvey-z3q
Copy link
Collaborator Author

After this, would it be possible to release a new version on the forge, or does @basti1302 need to do that?

Copy link
Owner

@heini heini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @basti1302 doesn't really care anymore, so you might want to s/basti1302/heini/g. I'll then take care to make a new release under that name.

Changing project URL and documentation to indicate that Dirk Heinrichs
is the new maintainer of the project.

Bump major version due to rewrite.
@alex-harvey-z3q
Copy link
Collaborator Author

Ok updated. I bumped the major version to 2.0.0 based on the rewrite, whereas bumping it to 1.0.0 didn't feel right. Also, I made some simple notes on how to use Blacksmith to push to forge at this other project I maintain. https://github.com/alexharv074/puppet-firewall_multi

@basti1302
Copy link
Collaborator

For the record, if there is anything you need my help with for publishing a new release, I can do that. But as @heini said, I've not used Puppet in years, so just publishing under a new account name is probably a good idea. If you want to and if it helps, we can release a final version under my basti1302 Puppet Forge account with a deprecation notice that links to the new Puppet Forge project/url, so that existing users find the new home of this project more easily (if that is even necessary, I don't know).

@heini
Copy link
Owner

heini commented Jul 5, 2018

Sorry for replying late. @basti1302, that would be a good idea, I think.

@basti1302
Copy link
Collaborator

Can you prepare a branch with the content you want to be published under my forge account? I'll do the publish from that branch then.

@alex-harvey-z3q
Copy link
Collaborator Author

@basti1302 , @heini I checked with the Puppet community. Apparently, the process for deprecating at the Forge would be:

  • Checkout the last version prior to all our changes
  • Manually edit metadata.json
  • Change the version field to 999.999.999
  • Change the summary field to a deprecation notice that points to heini/puppet-wait-for
  • Add puppet-blacksmith to Gemfile
  • bundle install
  • bundle exec rake build
  • Set some vars:
export BLACKSMITH_FORGE_URL=https://forgeapi.puppetlabs.com
export BLACKSMITH_FORGE_USERNAME=basti1302
export BLACKSMITH_FORGE_PASSWORD=xxxxxxxxx
  • bundle exec rake module:push

@alex-harvey-z3q
Copy link
Collaborator Author

@heini Considering the above, I think we could just merge this now?

@heini heini merged commit c126d79 into master Jul 8, 2018
@alex-harvey-z3q
Copy link
Collaborator Author

@basti1302 , ignore the above. Apparently, we just need to raise a ticket in the Jira and Puppet will deprecate the module in the backend. I'll do that. No need to anything here. @heini however I guess you should release this first in your username ?

@basti1302
Copy link
Collaborator

@alexharv074 Thanks for figuring out the process. I'll just comply with your request and do nothing then. It's something I excel at ;-)

@alex-harvey-z3q
Copy link
Collaborator Author

Deprecation ticket in Jira raised here https://tickets.puppetlabs.com/browse/MODULES-7464

@heini
Copy link
Owner

heini commented Jul 15, 2018

Ah, yes. Thanks a lot. I thought there was still one step missing but I couldn't remember what it was...

@heini heini deleted the alexharvey/clean_up_docs branch July 15, 2018 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants