#571 Improve log action and message naming

helgoboss · Jun 9, 2022 · abcc973 · abcc973
1 parent 0357722
commit abcc973
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/main/src/domain/ui_util.rs b/main/src/domain/ui_util.rs
@@ -93,15 +93,15 @@ pub fn format_control_input_with_match_result(
 }
 
 pub fn log_virtual_control_input(instance_id: &InstanceId, msg: impl Display) {
-    log(instance_id, "Virtual control input", msg);
+    log(instance_id, "Virtual control", msg);
 }
 
 pub fn log_real_control_input(instance_id: &InstanceId, msg: impl Display) {
-    log(instance_id, "Real control input", msg);
+    log(instance_id, "Real control", msg);
 }
 
 pub fn log_real_learn_input(instance_id: &InstanceId, msg: impl Display) {
-    log(instance_id, "Real learn input", msg);
+    log(instance_id, "Real learn", msg);
 }
 
 pub fn log_target_control(instance_id: &InstanceId, msg: impl Display) {
@@ -130,9 +130,9 @@ pub fn log_output(instance_id: &InstanceId, reason: OutputReason, msg: impl Disp
 
 #[derive(Copy, Clone, Debug, Display)]
 pub enum OutputReason {
-    #[display(fmt = "Real feedback output")]
+    #[display(fmt = "Real feedback")]
     RealFeedback,
-    #[display(fmt = "Virtual feedback output")]
+    #[display(fmt = "Virtual feedback")]
     VirtualFeedback,
     #[display(fmt = "Lifecycle output")]
     Lifecycle,

diff --git a/main/src/infrastructure/ui/header_panel.rs b/main/src/infrastructure/ui/header_panel.rs
@@ -517,15 +517,15 @@ impl HeaderPanel {
                     vec![
                         item("Log debug info", || ContextMenuAction::LogDebugInfo),
                         item_with_opts(
-                            "Log incoming real messages",
+                            "Log real control messages",
                             ItemOpts {
                                 enabled: true,
                                 checked: session.real_input_logging_enabled.get(),
                             },
                             || ContextMenuAction::ToggleRealInputLogging,
                         ),
                         item_with_opts(
-                            "Log incoming virtual messages",
+                            "Log virtual control messages",
                             ItemOpts {
                                 enabled: true,
                                 checked: session.virtual_input_logging_enabled.get(),
@@ -541,15 +541,15 @@ impl HeaderPanel {
                             || ContextMenuAction::ToggleTargetControlLogging,
                         ),
                         item_with_opts(
-                            "Log outgoing virtual messages",
+                            "Log virtual feedback messages",
                             ItemOpts {
                                 enabled: true,
                                 checked: session.virtual_output_logging_enabled.get(),
                             },
                             || ContextMenuAction::ToggleVirtualOutputLogging,
                         ),
                         item_with_opts(
-                            "Log outgoing real messages",
+                            "Log real feedback messages",
                             ItemOpts {
                                 enabled: true,
                                 checked: session.real_output_logging_enabled.get(),