Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playtime: Enabling/disabling FX with PDC during REAPER playback totally destroys timing #1180

Closed
helgoboss opened this issue Sep 9, 2024 · 1 comment
Labels
bug Something isn't working playtime Related to Playtime
Milestone

Comments

@helgoboss
Copy link
Owner

helgoboss commented Sep 9, 2024

The following issue can be observed when having latency-heavy FX on the master FX chain. It's PDC-related.

Can easily be tested by putting ReaFir on the master track with a huge FFT size (e.g. 32768).

Enabling/disabling such FX while REAPER is playing, retriggers clips

This should ideally be fixed by using a form of resyncing (by tracking a hypothetical playback position).

Reported by jimmydeluxe: https://www.youtube.com/watch?v=EhjGHFEyW3I

For the case that REAPER transport is stopped, this has already been solved in #1164.

@helgoboss
Copy link
Owner Author

helgoboss commented Sep 10, 2024

When fixing this with Justin's addition, I should also check if leftward smooth-seek and looping works with high-latency FX.

helgoboss added a commit that referenced this issue Sep 13, 2024
@helgoboss helgoboss added this to the 2.16.5 milestone Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working playtime Related to Playtime
Projects
Status: Done
Development

No branches or pull requests

1 participant