Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to create Reaper Actions for Realearn's controls. Specifically, the "Learn Target" Function #744

Closed
cldswm opened this issue Nov 9, 2022 · 12 comments
Closed

Ability to create Reaper Actions for Realearn's controls. Specifically, the "Learn Target" Function #744

cldswm opened this issue Nov 9, 2022 · 12 comments
Labels
enhancement New feature or request next realearn Related to ReaLearn

Comments

@cldswm
Copy link

cldswm commented Nov 9, 2022

In the forum we discussed whether if there was a possibility to have the ability for the user of Realearn to be able to access the learn target function for any Mappings they desire.

I've thought about 2 possible methods for this to happen:

  1. With the current ability to target another instance of Realearn, allowing user to activate/ deactivate instances , mappings, save & load snapshots as well as navigating within the Realearn UI. Was there also a possibility to create Target Controls for the Learn Target function ? This would be achieved by using TAGS. But the problem is that currently its not possible to use TAGS from another instance of Realearn if I'm correct.

  2. Another way of doing this could be just to allow users to create Reaper ACTIONS that refer to Realearn's functions, such as Learn Target.

Am not sure which one would be easier to implement, but would be interesting for a discussion.

Thanks!
@cldswm cldswm changed the title FR: Ability to create Reaper Actions for Realearn's controls. Specifically, the "Learn Target" Function Ability to create Reaper Actions for Realearn's controls. Specifically, the "Learn Target" Function Nov 9, 2022
@helgoboss
Copy link
Owner

Okay, so you want ReaLearn instance A to switch "Learn target" of a particular mapping in ReaLearn instance B. Correct?

Then I think it would make sense to add a new target "ReaLearn: Learn target of mapping" that allows you to choose a ReaLearn instance (This or a particular one or all tagged) and a mapping (particular one or first one tagged).

@helgoboss helgoboss added the enhancement New feature or request label Nov 9, 2022
@cldswm
Copy link
Author

cldswm commented Nov 9, 2022 via email

@cldswm
Copy link
Author

cldswm commented Jan 28, 2023

HI was wondering if this will get implemented any time soon. thanks!

@helgoboss helgoboss added the next label Jan 28, 2023
@helgoboss
Copy link
Owner

Starting to work on it now. It would enable a bunch of cool stuff, such as FX parameter pinning.

@helgoboss
Copy link
Owner

I will implement it in a slightly more simple way. Learning source/target for multiple mappings at once is not possible (nor desirable, I think) - only one mapping can be in learn mode for one ReaLearn instance at a time. Mapping tags are a technique to refer to multiple mappings at once, it's overkill and confusing to use it to refer to just one specific mapping. So I think a simple mapping picker would be better suited here. This also implies that we shouldn't use tags to refer to a ReaLearn instance - because the tag could match multiple instances. So I will provide an instance picker instead.

@cldswm
Copy link
Author

cldswm commented Feb 14, 2023 via email

@cldswm
Copy link
Author

cldswm commented Feb 14, 2023 via email

helgoboss added a commit that referenced this issue Feb 14, 2023
@helgoboss
#744 Change learning mapping when learning source/target while other …
831fe9a 
…mapping learning already
helgoboss added a commit that referenced this issue Feb 14, 2023
@helgoboss
#744 First draft of new target "ReaLearn: Learn mapping"
4fc30e4 
Feedback and targeting foreign instances is not yet working!
@helgoboss
Copy link
Owner

Woah, a bit tricky to implement, the part talking to other instances. But getting there.

helgoboss added a commit that referenced this issue Feb 14, 2023
@helgoboss
#744 Make foreign instance pickable
a6e19c9 
- foreign instance not yet processed
- loading foreign instance reference has load order issues
helgoboss added a commit that referenced this issue Feb 14, 2023
@helgoboss
#744 Fix load order issues
343a6af
@cldswm
Copy link
Author

cldswm commented Feb 16, 2023 via email

helgoboss added a commit that referenced this issue Feb 18, 2023
@helgoboss
#744 Name target more generally: "Modify mapping" instead of "Learn m…
0bbd357 
…apping"
helgoboss added a commit that referenced this issue Feb 20, 2023
@helgoboss
#744 Make it possible to switch target learning off again
893c2c4
helgoboss added a commit that referenced this issue Feb 20, 2023
@helgoboss
#744 Remove ability to learn source
40bfdf8 
- Had the issue that it would learn the release-button event
  corresponding to the button-press event that triggered the learn
  function. This is non-trivial to fix in a clean way.
- Doesn't appear to be worth the trouble now, not so useful anyway.
helgoboss added a commit that referenced this issue Feb 20, 2023
@helgoboss
#744 Make "Learn target" feedback work for own mappings
89f92e9
helgoboss added a commit that referenced this issue Feb 20, 2023
@helgoboss
#744 Make "Learn target" feedback work for foreign mappings as well
7fc0803
@helgoboss
Copy link
Owner

helgoboss commented Feb 20, 2023 •
edited
Loading

This will be available in upcoming version 2.15.0-pre.1. Name of the new target is "ReaLearn: Modify mapping". It allows you to pick a ReaLearn instance (by default <This>) and a mapping within that instance. Then you can pick what it does. At the moment only "Learn target" is available. But in future, this might offer doing other things as well, e.g. changing other mapping properties. One particular that I have in mind for near future: "Set target to last-touched".

Before I release this, I still want to implement #493 and combine the two. One should be able to define which target types should be learnable, otherwise it could pick up unwanted events.

@cldswm
Copy link
Author

cldswm commented Feb 23, 2023 via email

@cldswm
Copy link
Author

cldswm commented Feb 23, 2023 via email

helgoboss added a commit that referenced this issue Feb 28, 2023
@helgoboss
#744 Add row label for "Modify mapping" target
ad64e03
helgoboss added a commit that referenced this issue Feb 28, 2023
@helgoboss
#744 Fix target picker for mapping modification "Set to last touched …
1438f3a 
…target"
helgoboss added a commit that referenced this issue Apr 7, 2023
@helgoboss
#744 Include all targets by default
70e545c
@helgoboss helgoboss added the realearn Related to ReaLearn label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request next realearn Related to ReaLearn
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@helgoboss @cldswm