Added I_VUMODE to the track attribute enum #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helgoboss/helgobox#560 Followed formatting on the Enum
AlbertoV5
added a commit
to AlbertoV5/realearn
that referenced
this pull request
Apr 12, 2022
helgoboss#560 and helgoboss/reaper-rs#55 Compiled and passed the tests. Just an idea, works for me but I don't know what is best practice for mutable variables so edit as you see fit please and thank you. Looks like all VU modes use channels 1-2, except for Multichannel and Combined RMS. In Reaper's UI the mode Stereo RMS displays different values for channel 1 and 2 but Track Peak only returns a single value so it acts like Combined Stereo RMS in practice which for me personally is fine. Then currently as of 6.53 all LUFS meters follow channels 1-2 only.
AlbertoV5
added a commit
to AlbertoV5/realearn
that referenced
this pull request
May 14, 2022
Just a heads up that TrackAttributeKey::VuMode was added here: helgoboss/reaper-rs#55
helgoboss
requested changes
Jun 1, 2022
|
I'll just merge this and fix it myself. Thanks. |
|
Oh sorry, I thought I had done it right. Thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helgoboss/helgobox#560
Followed formatting on the Enum