Need to support no-op Gauge after all

helidon-io · Nov 19, 2021 · 0bcaedc · 0bcaedc
1 parent c74a984
commit 0bcaedc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/metrics/api/src/main/java/io/helidon/metrics/api/NoOpMetricImpl.java b/metrics/api/src/main/java/io/helidon/metrics/api/NoOpMetricImpl.java
@@ -112,6 +112,11 @@ static class NoOpGaugeImpl<T /* extends Number */> extends NoOpMetricImpl implem
             return new NoOpGaugeImpl<>(registryType, metadata, metric);
         }
 
+        static <S /* extends Number */> NoOpGaugeImpl<S> create(String registryType, Metadata metadata) {
+            // TODO uncomment above once MP metrics enforces the Number restriction
+            return new NoOpGaugeImpl<>(registryType, metadata, () -> null);
+        }
+
         private NoOpGaugeImpl(String registryType, Metadata metadata, Gauge<T> metric) {
             super(registryType, metadata);
             value = metric::getValue;

diff --git a/metrics/api/src/main/java/io/helidon/metrics/api/NoOpMetricRegistry.java b/metrics/api/src/main/java/io/helidon/metrics/api/NoOpMetricRegistry.java
@@ -30,9 +30,8 @@
 class NoOpMetricRegistry extends AbstractRegistry<NoOpMetric> {
 
     private static final Map<MetricType, BiFunction<String, Metadata, NoOpMetric>> NO_OP_METRIC_FACTORIES =
-            // Omit gauge because creating a gauge requires an existing delegate instance.
-            // These factory methods do not use delegates.
             Map.of(MetricType.COUNTER, NoOpMetricImpl.NoOpCounterImpl::create,
+                   MetricType.GAUGE, NoOpMetricImpl.NoOpGaugeImpl::create,
                    MetricType.HISTOGRAM, NoOpMetricImpl.NoOpHistogramImpl::create,
                    MetricType.METERED, NoOpMetricImpl.NoOpMeterImpl::create,
                    MetricType.TIMER, NoOpMetricImpl.NoOpTimerImpl::create,