Special treatment for ParamConverterProviders with multiple apps #3846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tered in the shared injection manager when more than one application is present. This ensures they are all properly installed; otherwise, Jersey will only consider those known after the first of the applications is registered. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
…ding ParamConverterProviders via class scanning. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
spericas
changed the title
tjquinno
approved these changes
Feb 1, 2022
spericas
added a commit
to spericas/helidon
that referenced
this pull request
Feb 1, 2022
…idon-io#3846) * Special treatment for ParamConverterProviders. They are now all registered in the shared injection manager when more than one application is present. This ensures they are all properly installed; otherwise, Jersey will only consider those known after the first of the applications is registered. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> * Updated copyright year. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> * New approach that calls getClasses/getSingletons and does require finding ParamConverterProviders via class scanning. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> * Restore ExceptionMapper registration statement. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> * Fixed support for singletons and additional testing. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
spericas
added a commit
that referenced
this pull request
Feb 2, 2022
…ter) (#3857) * Special treatment for ParamConverterProviders with multiple apps (#3846) * Special treatment for ParamConverterProviders. They are now all registered in the shared injection manager when more than one application is present. This ensures they are all properly installed; otherwise, Jersey will only consider those known after the first of the applications is registered. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> * Updated copyright year. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> * New approach that calls getClasses/getSingletons and does require finding ParamConverterProviders via class scanning. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> * Restore ExceptionMapper registration statement. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> * Fixed support for singletons and additional testing. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> * Fixed Helidon version after cherry-pick. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> * Fixed imports. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> * Renamed javax packages in imports. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Special treatment for ParamConverterProviders. They are now all registered in the shared injection manager when more than one application is present. This ensures they are all properly installed; otherwise, Jersey will only consider those known after the first of the applications is registered. See issue #3796.
Signed-off-by: Santiago Pericasgeertsen santiago.pericasgeertsen@oracle.com