Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Doc PR] Tracing documentation update. #4555

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

tomas-langer
Copy link
Member

This PR does changes in sources, so not marking it as draft.

Signed-off-by: Tomas Langer tomas.langer@oracle.com

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Copy link
Contributor

@m0mus m0mus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving it with some comments which can be addressed later:

  • ToC -> Contents
  • Zipking and Jaeger tracers are included in Additional Information section. I am suggesting moving them to Usage section. Or even remove Usage section at all and move all stuff from there ro the root and change ToC accordingly.

@m0mus m0mus merged commit a1f226e into helidon-io:master Jul 15, 2022
@tomas-langer tomas-langer deleted the docs-tracing branch July 15, 2022 12:58
romain-grecourt pushed a commit to MadsBrun/helidon that referenced this pull request Jul 21, 2022
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants