Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lang. Rev. Applied Doc] - Helidon MP integrations Neo4j #4639

Closed
wants to merge 1 commit into from
Closed

[Lang. Rev. Applied Doc] - Helidon MP integrations Neo4j #4639

wants to merge 1 commit into from

Conversation

dalexandrov
Copy link
Contributor

Applied language review for closed PR #4598

@dalexandrov dalexandrov added docs 3.x Issues for 3.x version branch labels Jul 29, 2022
@dalexandrov dalexandrov added this to the 3.0.1 milestone Jul 29, 2022
@dalexandrov dalexandrov self-assigned this Jul 29, 2022
@dalexandrov
Copy link
Contributor Author

/trigger

@dalexandrov dalexandrov requested a review from ljamen August 5, 2022 11:58
@barchetta barchetta changed the base branch from master to helidon-3.x August 8, 2022 21:53
ljamen
ljamen approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

@barchetta
Copy link
Member

This PR does not build due to:

[ERROR]
[ERROR] possible invalid reference: Neo4j Metrics propagation
[ERROR]     at se/integrations/neo4j.adoc:50
[ERROR]     at includes/dependencies.adoc:21
[ERROR]     at se/integrations/neo4j.adoc:1

@ljamen ljamen mentioned this pull request Aug 9, 2022
Merged
@ljamen
Copy link
Contributor

ljamen commented Aug 9, 2022

replaced by PR #4692

@ljamen ljamen closed this Aug 9, 2022
@dalexandrov dalexandrov deleted the 4299_Doc_Helidon_MP_Integrations_documentation_Neo4J branch September 12, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljamen ljamen ljamen approved these changes

Assignees

@dalexandrov dalexandrov

Labels
3.x Issues for 3.x version branch docs
Projects
None yet
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@dalexandrov @barchetta @ljamen