Fix OpenMetrics formatting error (3.x) #4900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith exemplars on SimpleTimer; add tests Signed-off-by: tim.quinn@oracle.com <tim.quinn@oracle.com>
This was referenced Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial problem was that the OpenMetrics output format was not quite right. It lacked a trailing
# EOF, it sometimes included a stray blank line, and we did not correctly deal withAcceptandContent-Typefor theapplication/openmetrics-textmedia type. (The issue was reported by a user who was having trouble with a Prometheus server that was set up to record exemplars complaining when it scraped a Helidon service's/metricsendpoint.)Along the way I discovered that exemplars for
SimpleTimerwere incorrect so that fix is part of this PR also.Signed-off-by: tim.quinn@oracle.com tim.quinn@oracle.com