5409 duration timeout #5709
Merged
5409 duration timeout #5709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: aserkes <andrii.serkes@oracle.com>
Signed-off-by: aserkes <andrii.serkes@oracle.com>
Signed-off-by: aserkes <andrii.serkes@oracle.com>
oracle-contributor-agreement
bot
added
the
OCA Verified
Signed-off-by: aserkes <andrii.serkes@oracle.com>
Signed-off-by: aserkes <andrii.serkes@oracle.com>
Signed-off-by: aserkes <andrii.serkes@oracle.com>
|
Please rebase on latest |
tomas-langer
requested changes
Dec 16, 2022
common/reactive/src/main/java/io/helidon/common/reactive/Awaitable.java
Outdated
Show resolved
Hide resolved
...narayana-client/src/main/java/io/helidon/lra/coordinator/client/narayana/NarayanaClient.java
Outdated
Show resolved
Hide resolved
...oordinator/client/spi/src/main/java/io/helidon/lra/coordinator/client/CoordinatorClient.java
Outdated
Show resolved
Hide resolved
reactive/health/src/main/java/io/helidon/reactive/health/HealthSupport.java
Outdated
Show resolved
Hide resolved
reactive/health/src/main/java/io/helidon/reactive/health/HealthSupport.java
Outdated
Show resolved
Hide resolved
aserkes
force-pushed
the
5409_duration_timeout
branch
2 times, most recently
from
1afe8f7
to
2e93169
Compare
Signed-off-by: aserkes <andrii.serkes@oracle.com>
Signed-off-by: aserkes <andrii.serkes@oracle.com>
tomas-langer
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Duration for our timeouts
Fixes #5409
I found other places where timeouts were used, but I am not sure do we really need to add methods that accepts
Durationoverthere. Usually in these places information about timeouts stored inlongorintfields which store duration of timeout in milliseconds and these fields are not used overthere to instantiateDurationinstances :