Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.x] Add built-in enum config support #5795

Merged
merged 2 commits into from
Jan 9, 2023
Merged

[4.x] Add built-in enum config support #5795

merged 2 commits into from
Jan 9, 2023

Conversation

tjquinno
Copy link
Member

@tjquinno tjquinno commented Jan 6, 2023

Resolves #5759

Forward-port of #5732

@tjquinno tjquinno self-assigned this Jan 6, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 6, 2023
@tjquinno
Copy link
Member Author

tjquinno commented Jan 6, 2023

@tomas-langer I changed from Priority to Weight for the built-in enum mapper and used the default weight. Let me know if this should change.

@danielkec
Copy link
Contributor

Looks good

@tjquinno tjquinno merged commit 4218c68 into helidon-io:main Jan 9, 2023
@tjquinno tjquinno deleted the config-enum-4.x branch January 9, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielkec danielkec danielkec approved these changes

@tomas-langer tomas-langer Awaiting requested review from tomas-langer

Assignees

@tjquinno tjquinno

Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjquinno @danielkec