Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nima: MicroMeter now contains Nima and SE integration #7090

Merged
merged 5 commits into from
Jun 27, 2023
Merged

Nima: MicroMeter now contains Nima and SE integration #7090

merged 5 commits into from
Jun 27, 2023

Conversation

jbescos
Copy link
Member

@jbescos jbescos commented Jun 26, 2023

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 26, 2023
@jbescos jbescos mentioned this pull request Jun 26, 2023
Closed
@jbescos jbescos force-pushed the issue5396_4 branch 4 times, most recently from 563f7eb to eedac63 Compare June 26, 2023 15:26
jbescos and others added 3 commits June 26, 2023 17:26
@jbescos
Nima: MicroMeter now contains Nima and SE integration
eedac63 
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
@romain-grecourt
- Use JUnit extension.
061d675 
- Split startServer into setupRouting to re-use in @setupServer in test
- Fix GreetService to next the request
- Rename methods and classes to remove "nima" from the name and align a little bit with 3.x
@romain-grecourt
use .build().start(), since .start() is not working somehow
6b937ec
@jbescos jbescos force-pushed the issue5396_4 branch 6 times, most recently from eb29952 to 1493a19 Compare June 27, 2023 06:18
@jbescos
Enable some tests
1493a19 
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
@jbescos
Merge branch 'main' into issue5396_4
5073525 
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
tjquinno
tjquinno approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a very quick look the changes LGTM.

@romain-grecourt romain-grecourt merged commit 29464db into helidon-io:main Jun 27, 2023
@romain-grecourt romain-grecourt mentioned this pull request Jun 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjquinno tjquinno tjquinno approved these changes

@romain-grecourt romain-grecourt romain-grecourt approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbescos @romain-grecourt @tjquinno