Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x: Config metadata docs #7581

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

tomas-langer
Copy link
Member

@tomas-langer tomas-langer commented Sep 13, 2023

Description

Resolves #5659

Update to all configured types, including the generated documentation.
Updated pom files that were missing processor configuration

Documentation

Removed types that no longer exist
Added new configured types
Re-generated configuration documentation in docs/config

Decision

This PR fails to build as existing documentation references non-existent configuration types. As I cannot fix this in the docs, we have to decide how to continue:

  1. Disable docs failure on cross references (if possible) - to be enabled once we fix docs
  2. Bring back types that no longer exist - to be removed once we fix the docs (a bit more complicated, as we would need to do a cross-check later again)
  3. Wait until docs can be modified and fix them as part of this PR

@tomas-langer tomas-langer added docs 4.x Version 4.x labels Sep 13, 2023
@tomas-langer tomas-langer added this to the 4.0.0-RC1 milestone Sep 13, 2023
@tomas-langer tomas-langer self-assigned this Sep 13, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 13, 2023
- remove references that no longer exist
- replace old configured types with new ones
- fix modules that did not generate config metadata
@tomas-langer
Copy link
Member Author

Rebased on latest main, fixed documentation for config

@romain-grecourt romain-grecourt merged commit 48318e0 into helidon-io:main Sep 18, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x docs OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants