Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.x: Upgrade okhttp3. Use OCI SDK BOM #7712

Merged
merged 2 commits into from
Oct 4, 2023
Merged

4.x: Upgrade okhttp3. Use OCI SDK BOM #7712

merged 2 commits into from
Oct 4, 2023

Conversation

barchetta
Copy link
Member

@barchetta barchetta commented Oct 3, 2023 •
edited
Loading

Description

  • Upgrade okhttp3 to 4.11.0
  • Keep okio at 3.4.0
  • Jump through some hoops for dependency convergence. Instead of managing the version of kotlin-stdlib directly we exclude it from okhttp3 and defer to the version coming from okio.
  • Use OCI Bom because they fixed it

This has been rebased on PR #7711

Documentation

No impact

@barchetta barchetta added dependencies Pull requests that update a dependency file 4.x Version 4.x labels Oct 3, 2023
@barchetta barchetta self-assigned this Oct 3, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 3, 2023
romain-grecourt
romain-grecourt previously approved these changes Oct 4, 2023
View reviewed changes
ljnelson
ljnelson previously approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@ljnelson ljnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barchetta barchetta merged commit 312ea87 into helidon-io:main Oct 4, 2023
12 checks passed
dalexandrov pushed a commit to dalexandrov/helidon that referenced this pull request Oct 17, 2023
@barchetta @dalexandrov
4.x: Upgrade okhttp3. Use OCI SDK BOM (helidon-io#7712)
bdaceae 
* Upgrade okhttp3 and okio. Use OCI BOM
* Don't dependency manage kotlin. Fix typo.
@barchetta barchetta deleted the 4.x-okhttp branch January 11, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljnelson ljnelson ljnelson approved these changes

@romain-grecourt romain-grecourt Awaiting requested review from romain-grecourt

Assignees

@barchetta barchetta

Labels
4.x Version 4.x dependencies Pull requests that update a dependency file OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barchetta @ljnelson @romain-grecourt