Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x: Fix Mongo Dbclient + related example #8130

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

tvallin
Copy link
Member

@tvallin tvallin commented Dec 11, 2023

Description

fix #8128

Documentation

no impact

Signed-off-by: tvallin <thibault.vallin@oracle.com>
@tvallin tvallin added examples DB client Helidon DB Client 4.x Version 4.x labels Dec 11, 2023
@tvallin tvallin self-assigned this Dec 11, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 11, 2023
@Tomas-Kraus
Copy link
Member

I'm working on large DbClient integration tests change that will introduce testcontainers there. But looks like those 2 PRs are not in conflict. I'm fine with this one.

Copy link
Member

@Tomas-Kraus Tomas-Kraus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to double check the _id change. It was there to show primary key usage.

@Tomas-Kraus Tomas-Kraus self-requested a review December 11, 2023 14:42
Tomas-Kraus
Tomas-Kraus previously approved these changes Dec 11, 2023
Signed-off-by: tvallin <thibault.vallin@oracle.com>
@barchetta barchetta merged commit 13e6ea0 into helidon-io:main Dec 19, 2023
12 checks passed
@tvallin tvallin deleted the database-example branch January 2, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x DB client Helidon DB Client examples OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.x: Mongo Database example - Some endpoints do not work
4 participants