Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to any JDK from examples #8213

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Remove references to any JDK from examples #8213

merged 1 commit into from
Jan 9, 2024

Conversation

senivam
Copy link
Member

@senivam senivam commented Jan 9, 2024

Description

Removes references to JDKs from examples

@senivam
Remove references to any JDK from examples
22e3162 
Signed-off-by: Maxim Nesen <maxim.nesen@oracle.com>
@senivam senivam self-assigned this Jan 9, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 9, 2024
@senivam senivam linked an issue Jan 9, 2024 that may be closed by this pull request
Example READMEs still reference JDK11 #8182
Closed
@senivam senivam added examples 4.x Version 4.x labels Jan 9, 2024
@senivam
Copy link
Member Author

senivam commented Jan 9, 2024

there is one reference to JDK (21) in archetypes:

archetypes/helidon/src/main/archetype/common/files/README.md.mustache

if it shall also be removed please let me know

@senivam senivam requested a review from barchetta January 9, 2024 12:32
barchetta
barchetta approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think it is OK to leave the JDK pre-req in the archetype since that is just one place to change.

@barchetta barchetta merged commit b496172 into helidon-io:main Jan 9, 2024
12 checks passed
@senivam senivam deleted the 4x_examples_jdk branch January 10, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barchetta barchetta barchetta approved these changes

Assignees

@senivam senivam

Labels
4.x Version 4.x examples OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Example READMEs still reference JDK11
2 participants
@senivam @barchetta