Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Map<String, String> in configured builders. #8231

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

tomas-langer
Copy link
Member

Description

Resovles #8217

Adds explicit support for type Map<String, String>, and instead of doing the "complicated" get from config, it uses config.detach().asMap() to get the child values

@tomas-langer tomas-langer added config builder Related to the builder support labels Jan 12, 2024
@tomas-langer tomas-langer self-assigned this Jan 12, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 12, 2024
Copy link
Member

@Tomas-Kraus Tomas-Kraus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tomas-langer tomas-langer merged commit e583a9f into helidon-io:main Jan 12, 2024
12 checks passed
@tomas-langer tomas-langer deleted the 8217-config-map branch January 12, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builder Related to the builder support config OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants