Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After retrieval check baggage entry for null before dereferencing it #8885

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

tjquinno
Copy link
Member

@tjquinno tjquinno commented Jun 13, 2024

Description

Resolves #8882

Check the BaggageEntry retrieved from the map for null before attempting to get the entry's value to return.

Add test.

Documentation

Bug fix; no doc impact.

Signed-off-by: Tim Quinn <tim.quinn@oracle.com>
@tjquinno tjquinno self-assigned this Jun 13, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 13, 2024
@tjquinno tjquinno merged commit dc01487 into helidon-io:main Jun 25, 2024
12 checks passed
@tjquinno tjquinno deleted the 4.x-baggage-npe branch June 25, 2024 15:11
barchetta pushed a commit to barchetta/helidon that referenced this pull request Jul 12, 2024
…elidon-io#8885)

* After retrieval check baggage entry for null before dereferencing it

Signed-off-by: Tim Quinn <tim.quinn@oracle.com>

* Make test class pkg private; no need for it to be public

---------

Signed-off-by: Tim Quinn <tim.quinn@oracle.com>
barchetta added a commit that referenced this pull request Jul 12, 2024
…8885) (#8975)

* After retrieval check baggage entry for null before dereferencing it
* Make test class pkg private; no need for it to be public
---------
Signed-off-by: Tim Quinn <tim.quinn@oracle.com>
Co-authored-by: Tim Quinn <tim.quinn@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
2 participants