Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to push change to proto in oracles #399

Closed
wants to merge 1 commit into from

Conversation

jeffgrunewald
Copy link
Contributor

support pulling helium/proto#308 into oracles without dependency conflicts

@jeffgrunewald jeffgrunewald force-pushed the jg/temp-proto-upgrade branch from 60f60c1 to f636281 Compare March 21, 2023 21:41
@jeffgrunewald jeffgrunewald mentioned this pull request Mar 23, 2023
2 tasks
@jeffgrunewald jeffgrunewald force-pushed the jg/temp-proto-upgrade branch from f636281 to 7a5ef75 Compare March 28, 2023 21:31
@jeffgrunewald jeffgrunewald changed the title temp upgrade to push change to proto in oracles upgrade to push change to proto in oracles Mar 29, 2023
@jeffgrunewald jeffgrunewald force-pushed the jg/temp-proto-upgrade branch 4 times, most recently from e3e69eb to 08ad4f7 Compare March 30, 2023 08:03
Copy link
Contributor

@andymck andymck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you wanting to point main to a proto branch ? or is this temporary until that proto branch gets merged and then you will bump to point to latest master proto ?

If latter not sure why this is up for review atm ?

@jeffgrunewald
Copy link
Contributor Author

why are you wanting to point main to a proto branch ? or is this temporary until that proto branch gets merged and then you will bump to point to latest master proto ?

If latter not sure why this is up for review atm ?

This was ready for review for the mobile-config server PR but I needed a change in the underlying proto for the iot-config server work so i co-opted the PR. I should have it ready for review and merge again today but if I don’t I’ll close this and reopen it.

@jeffgrunewald jeffgrunewald force-pushed the jg/temp-proto-upgrade branch 4 times, most recently from 7f7802c to fb45c4d Compare March 31, 2023 00:15
@jeffgrunewald jeffgrunewald force-pushed the jg/temp-proto-upgrade branch 3 times, most recently from 7fd4dc6 to 9eba433 Compare April 5, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants