-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make helium-crypto-rs compilable with the latest ed25519-compact version #69
Conversation
Cargo.toml
Outdated
@@ -18,7 +18,7 @@ serde = { version = "1", features = ["derive"] } | |||
rand_core = "^0.6" | |||
getrandom = "0" | |||
sha2 = { version = "0.10", default-features = false, features = ["std", "oid"] } | |||
ed25519-compact = { version = "2", features = ["std", "traits"] } | |||
ed25519-compact = { version = "=2.0.6", features = ["std", "traits"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of pinning can you fix the issue so we don’t have to keep the ed crate in the past?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of pinning can you fix the issue so we don’t have to keep the ed crate in the past?
Ok will try to do that
752e10d
to
afa6de0
Compare
afa6de0
to
02eb848
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
==========================================
- Coverage 68.70% 67.63% -1.08%
==========================================
Files 12 12
Lines 898 862 -36
==========================================
- Hits 617 583 -34
+ Misses 281 279 -2
|
50c1345
to
642b113
Compare
642b113
to
02de724
Compare
@madninja Looks ready. I intentionally used |
Fix compiling issue