Avoid line endings conversion of gradlew.bat #944
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fresh clone of this repo shows the file
gradlew.bat
as modified:The reason is a configuration which will convert line endings when the file is placed in the working directory. This conversion in unnecessary, as the file
gradlew.bat
is generated by Gradle'swrapper
task with the correct line endings. It should not be modified manually. This has already been fixed on react-native's main branch: facebook/react-native#31398