Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid line endings conversion of gradlew.bat #944

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

friederbluemle
Copy link
Contributor

A fresh clone of this repo shows the file gradlew.bat as modified:

$ git clone https://github.com/helium/hotspot-app.git && cd hotspot-app/
// ...
$ git status
On branch main
Your branch is up to date with 'origin/main'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   android/gradlew.bat

The reason is a configuration which will convert line endings when the file is placed in the working directory. This conversion in unnecessary, as the file gradlew.bat is generated by Gradle's wrapper task with the correct line endings. It should not be modified manually. This has already been fixed on react-native's main branch: facebook/react-native#31398

@tyler-whitman
Copy link
Contributor

@friederbluemle thanks for this change. It looks like they ended up going with facebook/react-native#32178 so maybe these files should remain?

We could update react native and pull those changes in to resolve this issue I believe.

@friederbluemle
Copy link
Contributor Author

@friederbluemle thanks for this change. It looks like they ended up going with facebook/react-native#32178 so maybe these files should remain?

We could update react native and pull those changes in to resolve this issue I believe.

The PR you referenced only fixed the gradlew.bat line endings in React Native's repo. The files in your repository are already correct, so no conversion is necessary.

@tyler-whitman
Copy link
Contributor

@friederbluemle thanks for this change. It looks like they ended up going with facebook/react-native#32178 so maybe these files should remain?
We could update react native and pull those changes in to resolve this issue I believe.

The PR you referenced only fixed the gradlew.bat line endings in React Native's repo. The files in your repository are already correct, so no conversion is necessary.

So we should still remove these files?

@friederbluemle
Copy link
Contributor Author

I would say yes, because:

  1. It'll fix the problem stated in the PR description
  2. They are already removed on RN's main branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants