IoT Packet Verifier #267
Merged
IoT Packet Verifier #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andymck
reviewed
Jan 25, 2023
andymck
reviewed
Jan 25, 2023
| @@ -106,6 +106,9 @@ pub const VALIDATED_HEARTBEAT: &str = "validated_heartbeat"; | |||
| pub const SIGNED_POC_RECEIPT_TXN: &str = "signed_poc_receipt_txn"; | |||
| pub const RADIO_REWARD_SHARE: &str = "radio_reward_share"; | |||
| pub const REWARD_MANIFEST: &str = "reward_manifest"; | |||
| pub const IOT_PACKET_REPORT: &str = "packet_report"; | |||
| pub const VALID_PACKET: &str = "valid_packet"; | |||
There was a problem hiding this comment.
can you add the filestore conversions for the proto <-> internal structs for valid and invalid packets
There was a problem hiding this comment.
Yup, I certainly can
bbalser
approved these changes
Feb 22, 2023
madninja
reviewed
Feb 22, 2023
jeffgrunewald
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.