Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iot config session key service #345

Merged
merged 3 commits into from
Mar 7, 2023
Merged

iot config session key service #345

merged 3 commits into from
Mar 7, 2023

Conversation

michaeldjeffrey
Copy link
Contributor

  • removed unique constraint on owner_pubkey in the organizations table.
  • If an org is deleted, session_key remove updates will not be sent out. I'm not sure if this is a terribly huge problem, as they're removed from the DB, and will not be resent on a fresh connection.

andymck
andymck approved these changes Feb 9, 2023
View reviewed changes
iot_config/src/session_key.rs Show resolved Hide resolved
iot_config/src/session_key_service.rs Outdated Show resolved Hide resolved
iot_config/src/session_key_service.rs
.await
.map_err(|_| Status::internal("list session key filters failed"))?;

let (tx, rx) = tokio::sync::mpsc::channel(20);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add a const for the buffer size, used in multiple places so be simpler to bump size

@jeffgrunewald jeffgrunewald force-pushed the mj/iot-config-session-key-service branch 4 times, most recently from f7c052b to e7a272d Compare March 3, 2023 23:54
@jeffgrunewald jeffgrunewald force-pushed the mj/iot-config-session-key-service branch 2 times, most recently from 3e79937 to 8419499 Compare March 7, 2023 22:01
@jeffgrunewald jeffgrunewald force-pushed the mj/iot-config-session-key-service branch from 8419499 to a2b74a0 Compare March 7, 2023 22:53
@jeffgrunewald jeffgrunewald merged commit dbd1f26 into main Mar 7, 2023
@jeffgrunewald jeffgrunewald deleted the mj/iot-config-session-key-service branch March 7, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbalser bbalser bbalser approved these changes

@andymck andymck andymck approved these changes

@macpie macpie Awaiting requested review from macpie

@jeffgrunewald jeffgrunewald Awaiting requested review from jeffgrunewald

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaeldjeffrey @andymck @bbalser @jeffgrunewald