Use seconds precision for entropy timestamp. Use hotspot generated entropy inputs and outputs for beacon verification test #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andymck
force-pushed
the
andymck/beacon-payload-test-additions
branch
from
d990687 to
76ce123
Compare
andymck
changed the title
bbalser
reviewed
Feb 14, 2023
bbalser
reviewed
Feb 14, 2023
andymck
force-pushed
the
andymck/beacon-payload-test-additions
branch
from
76ce123 to
40c772f
Compare
madninja
approved these changes
Feb 14, 2023
bbalser
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a mismatch on the beacon generation on the verifier with that of the beacon generation on hotspots where the resultant generated data payload values did not match.
The root cause of the issue was that the verifier was passing in millisecs precision for its remote entropy timestamp value when generating the beacon to verify whereas the hotspots uses seconds precision.