Add PriceTracker to Price Oracle

[bbalser]

No description provided.

[jeffgrunewald]

looks like this branch had an older commit from rg/price force-pushed to it; there are a bunch of small things that have been changed on that branch as a result of PR feedback that are still in play here so this should get rebased on the latest commit there unless it gets merged into main first

[madninja]

I don't quite get why price_tracker.rs is in the file_store at all.. We have none of the other services declare types here so why this one?

[jeffgrunewald]

I don't quite get why price_tracker.rs is in the file_store at all.. We have none of the other services declare types here so why this one?

i wondered about that; seems like a reasonable if imprecise place to put it since it's technically just a client for streaming price_report files and there was little enough code required that it seems overkill to put it in its own crate

[bbalser]

I don't quite get why price_tracker.rs is in the file_store at all.. We have none of the other services declare types here so why this one?

i wondered about that; seems like a reasonable if imprecise place to put it since it's technically just a client for streaming price_report files and there was little enough code required that it seems overkill to put it in its own crate

I originally created a new price_tracker crate, but it felt like overkill, but I can go back to that if we feel that is a better home.

[madninja]

I don't quite get why price_tracker.rs is in the file_store at all.. We have none of the other services declare types here so why this one?

i wondered about that; seems like a reasonable if imprecise place to put it since it's technically just a client for streaming price_report files and there was little enough code required that it seems overkill to put it in its own crate

I originally created a new price_tracker crate, but it felt like overkill, but I can go back to that if we feel that is a better home.

yes please? it's a running service/oracle right? not just a utility class

[bbalser]

I don't quite get why price_tracker.rs is in the file_store at all.. We have none of the other services declare types here so why this one?

i wondered about that; seems like a reasonable if imprecise place to put it since it's technically just a client for streaming price_report files and there was little enough code required that it seems overkill to put it in its own crate

I originally created a new price_tracker crate, but it felt like overkill, but I can go back to that if we feel that is a better home.

yes please? it's a running service/oracle right? not just a utility class

It is a task that will be ran in other services/oracles just like FileSink