Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add price metrics #406

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Add price metrics #406

merged 2 commits into from
Mar 10, 2023

Conversation

vihu
Copy link
Member

@vihu vihu commented Mar 10, 2023

Summary

This adds several price related metrics. Specifically a counter for update and a gauge to track the actual price value.

@vihu vihu marked this pull request as ready for review March 10, 2023 20:40
@vihu vihu force-pushed the rg/price-metrics branch from 73be5f4 to 1be7232 Compare March 10, 2023 20:40
@vihu vihu requested a review from jeffgrunewald March 10, 2023 20:41
jeffgrunewald
jeffgrunewald reviewed Mar 10, 2023
View reviewed changes
price/src/metrics.rs Outdated Show resolved Hide resolved
Base automatically changed from rg/price to main March 10, 2023 21:44
vihu added 2 commits March 10, 2023 14:44
@vihu
Add price metrics
be284fd
@vihu
Address review cmt
92e24ad 
- Separate counters for updated and stale price
@vihu vihu force-pushed the rg/price-metrics branch from 09137a5 to 92e24ad Compare March 10, 2023 21:46
@vihu vihu merged commit ad47968 into main Mar 10, 2023
@vihu vihu deleted the rg/price-metrics branch March 10, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffgrunewald jeffgrunewald jeffgrunewald approved these changes

@bbalser bbalser bbalser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vihu @bbalser @jeffgrunewald