Refactor to support IotRewardShare and multiple sub reward types. Add support for operation fund rewards #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andymck
force-pushed
the
andymck/operation-fund-rewards
branch
2 times, most recently
from
710502d to
d47f6f3
Compare
andymck
changed the title
andymck
force-pushed
the
andymck/operation-fund-rewards
branch
2 times, most recently
from
3e416a4 to
39aed05
Compare
andymck
force-pushed
the
andymck/operation-fund-rewards
branch
from
431b777 to
ef4f1f0
Compare
bbalser
approved these changes
Apr 10, 2023
jeffgrunewald
approved these changes
Apr 10, 2023
maplant
reviewed
Apr 10, 2023
Co-authored-by: Matthew Plant <matty@nova-labs.com>
maplant
reviewed
Apr 10, 2023
Comment on lines
23
to
30
| static ref WITNESS_REWARDS_PER_DAY_PERCENT: Decimal = dec!(0.24); | ||
| // Data transfer is allocated 50% of daily rewards | ||
| static ref DATA_TRANSFER_REWARDS_PER_DAY_PERCENT: Decimal = dec!(0.50); | ||
| // Operations fund is allocated 7% of daily rewards | ||
| static ref OPERATIONS_REWARDS_PER_DAY_PERCENT: Decimal = dec!(0.07); | ||
| // dc remainer distributed at ration of 4:1 in favour of witnesses | ||
| // ie WITNESS_REWARDS_PER_DAY_PERCENT:BEACON_REWARDS_PER_DAY_PERCENT | ||
| static ref WITNESS_DC_REMAINER_PERCENT: Decimal = dec!(0.80); |
There was a problem hiding this comment.
All of these can be constants instead of lazy statics
maplant
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on proto branch: https://github.com/helium/proto
Refactor to replace GatewayRewardShare with IotRewardShare. IotRewardShare now supports multiple reward types each with their own data requirements.
Adds output of operational fund rewards