handle unknown lora region in config service gateway api #431
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is needed to handle gateways requesting region params when they do not have a valid or known default/fallback region set in their local settings.toml files when they make a request to the config service to get the current transmit parameters for their region.
The lookup/response from the config service will be prioritized as follows:
This change also changes the behavior of the API if the fallback region argument supplied in the gateway's request is not found to be a valid region. Where previously this would be converted to the enum default (first enum variant, us915) now it will return an "invalid argument" error to the client. For the purposes of this validation, the "unknown" region is considered a valid region.