fix double-encoding-to-vec on crypto signing responses #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maplant
approved these changes
Apr 11, 2023
andymck
approved these changes
Apr 12, 2023
bbalser
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
corrects a bug where we're calling
encode_to_vecon messages to sign and then passing that encoded response to a service impl method that does the same encoding again, thereby double-encoding the response before sendingalso removes the filter/setting/checks in the config services for helium crypto keys to be set to a particular Helium L1 network (mainnet vs. testnet) since this is likely no longer a valuable distinction to be made