commit file sinks after rewards db purged #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andymck
force-pushed
the
andymck/narrow-rewards-fail-gap
branch
from
6a9a26d to
5989ad7
Compare
andymck
force-pushed
the
andymck/narrow-rewards-fail-gap
branch
from
5989ad7 to
e4dca48
Compare
bbalser
approved these changes
Apr 25, 2023
maplant
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the verifiers to only output the rewards manifest files after the rewards themselves have been committed to s3 and in addition the DB has been purged, thus the manifest file will only show on disk if everything else went as expected.
This avoids the scenario whereby we write out the rewards files including manifest only to have the DB cleanup fail, resulting in the potential for the reward period to not be updated and we end up rerunning the same reward period again