converting helius-fed database to new foundation schema #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andymck
reviewed
May 3, 2023
| @@ -143,13 +144,16 @@ pub(crate) mod db { | |||
| db: impl PgExecutor<'_>, | |||
| address: &PublicKeyBinary, | |||
| ) -> anyhow::Result<Option<IotMetadata>> { | |||
| let entity_key = bs58::decode(address.to_string()).into_vec()?; | |||
There was a problem hiding this comment.
are you sure this gives you what you need ? seems odd to use a public key in a format not directly supported by crypto-rs
There was a problem hiding this comment.
I’d like to go through it with folks today but I’ve tested this locally with a dump of data and this is unfortunately what we need
andymck
approved these changes
May 3, 2023
bbalser
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the new database being fed from the solana chain stores the helium crypto public key address of the hotspots as a binary buffer of the b58 decoded address string, as well as splitting the hotspot metadata info between the
iot_hotspot_infostable where the metadata is stored and thekey_to_assetstable where the encoded pubkey address is stored. this change enables querying the new schema structure by the iot_config server (mobile_config server pending) without changing the RPC API the rest of the oracles use to lookup or stream hotspot on-chain metadata