-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
subscriber location rewards #530
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
andymck
force-pushed
the
andymck/location-sharing-rewards
branch
from
June 6, 2023 15:17
0bf3ccb
to
f1b17b2
Compare
bbalser
reviewed
Jun 12, 2023
andymck
force-pushed
the
andymck/location-sharing-rewards
branch
2 times, most recently
from
June 13, 2023 10:27
feb806f
to
2614848
Compare
maplant
reviewed
Jun 14, 2023
maplant
reviewed
Jun 14, 2023
andymck
force-pushed
the
andymck/location-sharing-rewards
branch
2 times, most recently
from
June 17, 2023 11:37
0043ed0
to
61561b7
Compare
bbalser
reviewed
Jun 21, 2023
bbalser
approved these changes
Jun 21, 2023
maplant
reviewed
Jun 21, 2023
jeffgrunewald
approved these changes
Jun 27, 2023
andymck
force-pushed
the
andymck/location-sharing-rewards
branch
from
June 27, 2023 15:11
c12472c
to
8be98a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked proto PR:
helium/proto#345
Adds support for subscriber location rewards
Linked HIP: https://github.com/helium/HIP/blob/main/0079-mobile-poc-mappers-rewards.md
Linked issue: #422
TODO:
Tested locally end to end, example of subscriber reward outputted :
{
"start_period": 1686052372,
"end_period": 1686138856,
"reward": {
"SubscriberReward": {
"subscriber_id": [
115,
117,
98,
115,
99,
114,
105,
98,
101,
114,
95,
120
],
"discovery_location_amount": 30000000
}
}
}