Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile config service supports subscriber rewards #546

Merged
merged 9 commits into from
Jun 16, 2023
Merged

Mobile config service supports subscriber rewards #546

merged 9 commits into from
Jun 16, 2023

Conversation

jeffgrunewald
Copy link
Contributor

  • Restructures the API around verifying authorized mobile network signing keys are registered to the config service (carrier or mobile router keys)
  • Adds verification for generic rewardable entities found on the blockchain or not by binary entity_id
  • Adds clients for both
  • Restructures the existing mobile gateway client code to align with the additional mobile clients

@jeffgrunewald jeffgrunewald force-pushed the jg/mobile-config-subscriber-rewards branch from a849901 to f1c4e83 Compare June 15, 2023 21:51
@jeffgrunewald jeffgrunewald marked this pull request as ready for review June 16, 2023 02:43
andymck
andymck reviewed Jun 16, 2023
View reviewed changes
mobile_verifier/src/cli/server.rs Outdated Show resolved Hide resolved
mobile_verifier/src/heartbeats.rs Outdated Show resolved Hide resolved
@jeffgrunewald @andymck
Update mobile_verifier/src/cli/server.rs
60e5c77 
Co-authored-by: andymck <andrewb.mckenzie@gmail.com>
maplant
maplant approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@maplant maplant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine on the iot packet verifier side. glad to have this stuff moved into the client

@jeffgrunewald jeffgrunewald merged commit 66f11b5 into main Jun 16, 2023
@jeffgrunewald jeffgrunewald deleted the jg/mobile-config-subscriber-rewards branch June 16, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbalser bbalser bbalser approved these changes

@andymck andymck andymck approved these changes

@maplant maplant maplant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeffgrunewald @maplant @andymck @bbalser