Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modeled Coverage - Phase 3 #559
Modeled Coverage - Phase 3 #559
Changes from 8 commits
0479b5f
498685e
bab457f
60814f7
e52dc60
e35ee73
7e04c77
54bcaed
ca0434d
da1ccb2
8a1e2a6
57da60b
ba97a7e
74d6eb8
64fa0b3
8c52ceb
a1c254d
6619bfd
99505a3
6b5c69e
035e4a9
242ad5a
349a92e
567bd35
a5c9d4d
9d1dffb
0f5cd3d
cb0ae3c
d886af8
5cd1b75
fee3eb3
e35c82b
985c990
d066c29
a71a601
1deea42
9c88a27
45638d5
8201e1b
9301ad7
b8b719b
eccb3f5
c2827a8
83f0ce6
12b9c96
e288a10
cf76f30
25d787a
34057e7
9ec0f69
9b38ab4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe not a concern depending on the expected volume of coverage objects, but
ulid-rs
may be good to keep in mind for "lexicographically sortable" IDs that are UUIDv4 compatible to prevent too much fragmentation in the databaseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would absolutely prefer ulids, but we are given the uuids. we don't decide them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason not to implement the MsgTimestamp trait to handle these timestamps here and in subsequent msgs below ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eh, just didn't see a reason to implement it to only be used one other place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its a matter of convention and ensuring consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you use
v.signal_level()
or are you explicitly avoiding the proto behavior of using the default (lowest/first) element of the signal level enum if the oracle doing thetry_from()
has an older version of the proto code that doesn't account for the variant in a newer message?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just happens to be the pattern I see everywhere else in the file store