Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IoT Config locked route updates and shutdown listeners #567

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

jeffgrunewald
Copy link
Contributor

Ensures that locked/disabled routes are still broadcast to the HPR servers so they are always available. HPRs check for a route's status (active and not disabled) anyway so they are only removed from the HPR when they are purposely deleted by an admin or operator.

Also adds more shutdown listeners to the long-running grpc streaming handlers to try and force the config service to respect and properly respond to sigterm messages sent from systemd when the service is being shut down (such as for update deployments).

@jeffgrunewald
Copy link
Contributor Author

After feedback from @maplant i modified the long-running streaming results responses to switch off a tokio::select!. He pointed out the previous versions of these shutdown checks would have been polling unnecessarily on each iteration of a loop instead of waiting on the select which will preempt the longer-running function if a shutdown is initiated.

@jeffgrunewald jeffgrunewald merged commit 0f6dc3f into main Jul 17, 2023
1 check passed
@jeffgrunewald jeffgrunewald deleted the jg/stream-locked-route-stuffs branch July 17, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants