add filestore new support #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andymck
force-pushed
the
andymck/filestore-new-support
branch
from
e1cfb4f
to
b6a9ddf
Compare
bbalser
approved these changes
Aug 10, 2023
jeffgrunewald
approved these changes
Aug 10, 2023
file_store/src/file_store.rs
Outdated
Comment on lines
74
to
78
| let region = if region.is_some() { | ||
| Region::new(region.unwrap()) | ||
| } else { | ||
| Region::new(settings::default_region()) | ||
| }; |
There was a problem hiding this comment.
Suggested change
| let region = if region.is_some() { | |
| Region::new(region.unwrap()) | |
| } else { | |
| Region::new(settings::default_region()) | |
| }; | |
| let region = Region::new(region.unwrap_or_else(|| settings::default_region())); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support non settings based creation of a filestore. Specifically added to allow the subscriber location service to instantiate a filestore without using a settings file