Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make valid packets for netid c00053 free #742

Merged
merged 3 commits into from
Feb 23, 2024
Merged

make valid packets for netid c00053 free #742

merged 3 commits into from
Feb 23, 2024

Conversation

jeffgrunewald
Copy link
Contributor

No description provided.

@bbalser
Copy link
Contributor

bbalser commented Feb 22, 2024

We should be looking at the free field in the packet report and if that is true, don't burn any dc. No need for specific netid checks in the packet verifier

@bbalser
Copy link
Contributor

bbalser commented Feb 23, 2024

In the iot_verifier, we will save a GatewayDCShare record to the db with a 0 for num_dcs burned, don't think it will hurt anything but we should probably just put in a check to not save it if num_dcs is 0.

@jeffgrunewald jeffgrunewald merged commit 0522ea0 into main Feb 23, 2024
1 check passed
@jeffgrunewald jeffgrunewald deleted the jg/free-c00053-packets branch February 23, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbalser bbalser bbalser approved these changes

@andymck andymck andymck approved these changes

@maplant maplant Awaiting requested review from maplant

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffgrunewald @bbalser @andymck