Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation error for projects that use oracles as dependency #773

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Fix compilation error for projects that use oracles as dependency #773

merged 1 commit into from
Apr 12, 2024

Conversation

kurotych
Copy link
Member

@kurotych kurotych commented Mar 27, 2024

Metrics dependency announced v0.22 with breaking changes that aren't supported by oracles
https://github.com/metrics-rs/metrics/blob/a143ef60b5354770fb292d29acc1f7bdef2c4aed/metrics/RELEASES.md#0220---2023-12-24

When I use the file_store as a dependency it doesn't compile until I add a patch fix to my project
image

[patch.crates-io]
metrics = { git = "https://github.com/metrics-rs/metrics", tag = "metrics-v0.21.1"}

Use metrics = 0.21 to let use oracles crates as a dependency without hack

@bbalser bbalser requested review from maplant and andymck April 3, 2024 10:07
@bbalser bbalser merged commit bfa8f91 into helium:main Apr 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants