track last beacon ts for schedule and recip separately. ensure only one beacon attempt per beaconing window #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne beacon attempt per beaconing window
Vagabond
approved these changes
Apr 4, 2024
bbalser
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further tweaks associated with hip106 side effects.
With this change we now track the time a gateway last submitted a beacon separately from the beacon reciprocity timestamp. Previously we tracked a single timestamp for both purposes.
The last beacon timestamp is used to enforce the beacon schedule and is updated post verification of a received beacon. The timestamp is updated whether the beacon is valid or invalid and thus a gateway can only submit one beacon per beaconing window irrespective of the beacon being valid/invalid or rewardable/non rewardable.
The beacon reciprocity timestamp is used to enforce beacon reciprocity. This timestamp is updated post verification and only if the beacon is rendered valid and has at least one witness.