Gateway service info perms #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure where the mobile_hotspot_infos table exists, but I think this test does well enough keying off expected grpc error statuses.
michaeldjeffrey
requested review from
maplant,
macpie,
andymck,
bbalser and
jeffgrunewald
madninja
reviewed
Apr 20, 2024
The method before was named specifically for the info request, but the function signature was much looser than the name implied. Passing the request reduces the chance of messing up argument order, or misunderstanding the arguments. If at some point more methods require the ability for self authorization, hopefully a better abstraction will reveal itself.
bbalser
approved these changes
Apr 22, 2024
jeffgrunewald
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Mobile Config Gateway Service to allow gateways to request information about themselves.
ORA-350