Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ORA-426] Add speedtest average to radio_reward_v2 #853

Merged
merged 6 commits into from
Aug 15, 2024
Merged

[ORA-426] Add speedtest average to radio_reward_v2 #853

merged 6 commits into from
Aug 15, 2024

Conversation

kurotych
Copy link
Member

@kurotych kurotych commented Aug 9, 2024 •
edited
Loading

Add speedtest_average field to the radio_reward_v2
Minor: Fix dividing by zero in Speedtest:avg if array is empty

@kurotych kurotych force-pushed the kurotych/speedtest_avg_radio_reward_v2 branch 2 times, most recently from 14f0cea to 6b76103 Compare August 9, 2024 12:09
@kurotych kurotych force-pushed the kurotych/speedtest_avg_radio_reward_v2 branch from 6b76103 to 8b53dfb Compare August 9, 2024 12:15
@kurotych kurotych force-pushed the kurotych/speedtest_avg_radio_reward_v2 branch from 9a3a4d7 to e8532f2 Compare August 9, 2024 13:53
@kurotych kurotych force-pushed the kurotych/speedtest_avg_radio_reward_v2 branch from d6184aa to 96f9cef Compare August 9, 2024 14:27
@kurotych kurotych force-pushed the kurotych/speedtest_avg_radio_reward_v2 branch from 96f9cef to fa114a9 Compare August 9, 2024 14:34
@kurotych kurotych marked this pull request as ready for review August 9, 2024 14:43
@kurotych kurotych requested a review from bbalser August 9, 2024 15:08
bbalser
bbalser approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@bbalser bbalser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andymck
andymck approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@andymck andymck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than one noted nit re multiplier function, lgtm

@kurotych kurotych force-pushed the kurotych/speedtest_avg_radio_reward_v2 branch from 724446a to 601b4f1 Compare August 15, 2024 13:42
@kurotych kurotych merged commit be53f87 into main Aug 15, 2024
17 checks passed
@kurotych kurotych deleted the kurotych/speedtest_avg_radio_reward_v2 branch August 15, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andymck andymck andymck approved these changes

@bbalser bbalser bbalser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kurotych @andymck @bbalser