Make Solana Errors concrete types #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeldjeffrey
requested review from
macpie,
andymck,
bbalser and
jeffgrunewald
michaeldjeffrey
force-pushed
the
mj/reify-solana-errors
branch
from
f90891f to
d50f84e
Compare
bbalser
approved these changes
Dec 20, 2024
macpie
approved these changes
Dec 20, 2024
jeffgrunewald
approved these changes
Dec 20, 2024
may not be imported where the macro is used
michaeldjeffrey
force-pushed
the
mj/reify-solana-errors
branch
from
9e6c268 to
c68e017
Compare
When the rest of this code starts to use helium-lib proper, this error type will be removed in lieu of mocking a tonic::Status error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In attempting to bring the
helium-libPR #850 back up to speed, and considering the ability to incorporate tracking transactions usinghelium-lib, I was really struggling with all the generics.All the times an associated
Errortype was something other than the concrete type used by the actual implementation, it was()ofInfallible. So I thought it would be an okay idea to remove the associated types to make some of the errors paths easier to change up without having to chase down a bunch of generics.ErrorOrgstraitSolanaNetworktraitDebitertraitConfigServertraitPacketWritertraitErrorBurnErrorConfirmPendingErrorVerificationErrorMonitorErrorConfigServerErrortokio::select!in iot-packet-verifier burnerVerifier::verify