deprecate old heartbeat invalid reason; add new correct one #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffgrunewald
force-pushed
the
jg/update-heartbeat-invalid-error
branch
from
c1413c1 to
d901919
Compare
maplant
approved these changes
Apr 25, 2023
bbalser
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post-solana migration, gateways are no longer linked directly to an owner wallet (for validation purposes) so the existing
GatewayOwnerNotFounderror is no longer a valid option. This change deprecates the old invalid reason and adds a replacement for the situation where the mobile verifier cannot find the heartbeating gateway's pubkey address on the blockchain. (This is a distinct situation from the mobile gateway being asserted to a location which is not something mobile poc cares about at the time of this PR)