Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change min_refreshed_at to min_updated_at in gateway_info_v2 #434

Merged
merged 7 commits into from
Dec 17, 2024

Conversation

kurotych
Copy link
Member

@kurotych kurotych commented Dec 6, 2024

Related PR: helium/oracles#910

@kurotych kurotych changed the title min_refreshed_at => min_updated_at Change min_refreshed_at to min_updated_at in gateway_info_v2 Dec 9, 2024
@kurotych kurotych marked this pull request as ready for review December 9, 2024 15:33
@dcyoung
Copy link

dcyoung commented Dec 10, 2024

@kurotych i noticed the v2 endpoint only applies to the stream endpoint. Should the info or info_batch endpoints get a v2 as well?

@jeffgrunewald
Copy link
Contributor

may be out of scope for the immediate issue @kurotych is working on but i would tend to agree that we should update the gateway service to provide v2 implementations of the info and info batch rpcs since they won't otherwise have a mechanism for accessing the gateway info for a single hotspot or subset of the entire fleet that includes the new metadata from the chain.

the impl for the info_batch is the same as for the stream (they both return a stream of gateway info messages) but that one just passes the list of hotspot addresses as a filter to the database query

@kurotych
Copy link
Member Author

I agree. I will start work on it in the current PRs.

@dcyoung @jeffgrunewald

@kurotych kurotych marked this pull request as draft December 10, 2024 17:04
@kurotych kurotych marked this pull request as ready for review December 11, 2024 12:41
@kurotych kurotych merged commit b4c8c8f into master Dec 17, 2024
7 checks passed
@kurotych kurotych deleted the min_update_at branch December 17, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants