Option for docker interactive opt-out

helix-collective · Sep 3, 2020 · b5b79a5 · b5b79a5
1 parent bbe8b6c
commit b5b79a5
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/docker/run.ts b/docker/run.ts
@@ -18,6 +18,7 @@ export type DockerRunParams = {
   user?: DockerUserArg;
   workdir?: string;
   envvars?: string[];
+  interactive: boolean;
 };
 
 /// Options to run docker as current user
@@ -61,10 +62,14 @@ export function makeDockerRunCmd(img: string, params: DockerRunParams) : string[
   const cmd = [
     "docker",
     "run",
-    "-t",
-    "-i",
     "--rm",
   ];
+
+  if(params.interactive) {
+    cmd.push("--tty");
+    cmd.push("--interactive");
+  }
+
   for (const m of params.mounts || []) {
     if (m.type === "bind") {
       const args = [