color-modes should default to true?

[David-Else]

color-modes | Whether to color the mode indicator with different colors depending on the mode itself | false

Why does the setting color-modes default to false? Surely if the theme creator added those colors then it should be the default?

Most people won't look for the setting and will never know that the extra feature exists, I only just found it myself in dark_plus:

[the-mikedavis]

In the long-run I think we should remove the option altogether (so it would behave as always true). The color-modes option was introduced so that if you found it distracting you could disable it. Now we have theme inheritance though which we can use for the same effect. Similar features like mode-based cursor colors don't have corresponding options and can be disabled by changing the theme.

It would break configs to remove the option though, so I think we should change the default to true for now and eventually remove the option when we eventually change the configuration format away from TOML.