:cd not working on Windows with v0.6

[superlou]

Reproduction steps

1. Run hx in the command prompt
2. Try to cd to a different folder, e.g. "C:\opt"
3. Receive the error "Couldn't change the current working directory: The system cannot find the file specified. (os error 2)"

The expected behavior (release v0.5) is:

Environment

• Platform: Windows 10
• Helix version: v0.6 release (hx -V prints "helix")

~/.cache/helix/helix.log

(C:\Users\lsimons\AppData\Local\helix is empty)

[archseer]

\cc @ath3 could this be due to #1389 #1231 ?

@superlou can you replicate it on 3307f44 ? (One commit before #1231 got merged)

[superlou]

Unfortunately, I can't build on a Windows computer: our office Rust version is too old and I use Linux at home. I'll see if I can get our tool-chain updated.

[archseer]

@kirawi You are on Windows right? Can you try to narrow it down?

[kirawi]

I'm not sure if it's the same issue, but trying to :open a directory would give an unable to open <directory> error in the status line. Before, I believe it would have opened the file picker?

[superlou]

It definitely seems like it's related to Windows vs. Unix style paths. If I do :cd C:/opt (note the forward slash) it completes successfully:

Also, autocompleting paths on Windows seems to work so long as I use forward slashes.

[kirawi]

It seems like it wants to escape the backslash, so C:\\ works while C:\ doesn't.

[archseer]

I thought the fix for #1389 was odd, rather than converting Windows backslashes to slashes, it should patch the shellwords handling to work with backslashes if cfg(windows) I think?

[kirawi]

Yep, I can do that since I worked with shellwords' source for another project.

[archseer]

We don't import shellwords, we have our own implementation.

[archseer]

https://github.com/helix-editor/helix/blob/master/helix-core/src/shellwords.rs

[archseer]

An easy quickfix for the time being would be revert #1389 and conditionally use shellwords if we're not on windows, otherwise just split string on spaces like before.

[archseer]

Can someone test the latest master (7767703)? I also reverted #1389

[kirawi]

Seems like it works, but I notice that typing e.g. ..\ shows

instead of

[archseer]

Yeah but that was present previously before, I just reverted back to the old behavior. Fixed now in 3e4f815

[ChimpSpin]

Still getting this error if the path contains spaces.

[ath3]

I will work on this.